On Tue, Oct 06, 2015 at 02:10:41PM +0200, 'Oleg Ponomarev' via ganeti-devel wrote: > Currently memory_dom0 collected value is used for Xen and Kvm. In case > of Kvm collection is broken because the amount of memory used by > hypervisor includes the amount of memory used by instances as well. > Replace memory_dom0 with memory_node from hv_state parameter. > > Signed-off-by: Oleg Ponomarev <[email protected]> > --- > lib/masterd/iallocator.py | 1 + > src/Ganeti/HTools/Backend/IAlloc.hs | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-)
Here you're chaning a public interface, the iallocator interface (not widely used, but still public). Please also document this extension in the NEWS file. Rest LGTM (and thanks for making sure the changed htools still work on older Ganeti clusters). -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
