On Tue, Oct 13, 2015 at 11:10:15AM +0000, Helga Velroyen wrote: > LGTM, thanks > > On Wed, 7 Oct 2015 at 11:03 'Klaus Aehlig' via ganeti-devel < > [email protected]> wrote: > > > We reuse the example cluster from hsqueeze tests. Recall that, > > with target resources 0 hsqueeze could evacuate precisely 4 nodes. > > > > Signed-off-by: Klaus Aehlig <[email protected]> > > --- > > test/hs/shelltests/htools-hcheck.test | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/test/hs/shelltests/htools-hcheck.test > > b/test/hs/shelltests/htools-hcheck.test > > index d5bd0dd..35e8775 100644 > > --- a/test/hs/shelltests/htools-hcheck.test > > +++ b/test/hs/shelltests/htools-hcheck.test > > @@ -22,3 +22,5 @@ > > >>>/Cluster is not healthy: False/ > > >>>= 0 > > > > +./test/hs/hcheck -t $TESTDATA_DIR/hsqueeze-underutilized.data > > --machine-readable > > +>>>/HCHECK_INIT_GROUP_0_REDUNDANCY=4/
For completeness, it's better to also check the exit value; so I'd like to include the following interdiff. commit db682fd82dfb15c9f9e5099a43194a795982851b Author: Klaus Aehlig <[email protected]> Date: Tue Oct 13 15:13:09 2015 +0200 Interdiff [PATCH master 4/4] Add a test for redundancy level diff --git a/test/hs/shelltests/htools-hcheck.test b/test/hs/shelltests/htools-hcheck.test index 35e8775..854e045 100644 --- a/test/hs/shelltests/htools-hcheck.test +++ b/test/hs/shelltests/htools-hcheck.test @@ -24,3 +24,4 @@ ./test/hs/hcheck -t $TESTDATA_DIR/hsqueeze-underutilized.data --machine-readable >>>/HCHECK_INIT_GROUP_0_REDUNDANCY=4/ +>>>= 0 -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
