On Tue, Oct 13, 2015 at 03:43:59PM +0200, 'Oleg Ponomarev' via ganeti-devel wrote: > Make hv and disk states default fields with notSerializeDefaultField > flag set in haskell objects in order to make them consistent with > the corresponding fields in python objects. > > Partially cherry-picked from: 553363a33cfb00bbae88c94ae6408d6e1a81a194
I wouldn't call it a partial cherry pick; in deed, no hunk is equal to that of the cited commit. What about saying "In the spirit of 553363 in Ganeti 2.17, ..."? Maybe also add a reference to the commit that introduces those fields in python. The patch itself looks good. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
