On Tue, Oct 13, 2015 at 04:30:20PM +0200, 'Oleg Ponomarev' via ganeti-devel wrote: > Currently hv/disk_state_static parameters are supported only for cluster > object properly. For node groups and nodes they were introduced in > 2da9f556, however only on the python side. This could cause problems > during upgrades from old versions. > > This patch adds hv and disk states fields to haskell objects as a > notSerializedDefaultField which will fix the problem without the changes > in behaviour. Also it modifies corresponding haskell tests.
Instead of "haskell tests", I would say "arbitrary instances"; this is more precise and sounds less scary for a change on a stable branch. But your call, no need to resend. > > The patch is inspired by e78fb0d6 and 553363a3. > > Signed-off-by: Oleg Ponomarev <[email protected]> > --- > src/Ganeti/Objects.hs | 32 ++++++++++++++++++++------------ > test/hs/Test/Ganeti/Objects.hs | 8 +++++--- > 2 files changed, 25 insertions(+), 15 deletions(-) LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
