LGTM

On 10/19/2015 03:57 PM, 'Klaus Aehlig' via ganeti-devel wrote:
Adding this option allows the mond backend to also collect
dynamic data about memory usage. This is particularly useful
when balancing clusters with memory over commitment.

Signed-off-by: Klaus Aehlig <[email protected]>
---
  man/hbal.rst                      | 5 +++++
  src/Ganeti/HTools/Program/Hbal.hs | 1 +
  2 files changed, 6 insertions(+)

diff --git a/man/hbal.rst b/man/hbal.rst
index 8a7d684..389458b 100644
--- a/man/hbal.rst
+++ b/man/hbal.rst
@@ -36,6 +36,7 @@ Algorithm options:
  **[ \--ignore-soft-errors ]**
  **[ \--mond *yes|no* ]**
  **[ \--mond-xen ]**
+**[ \--mond-kvm-rss ]**
  **[ \--exit-on-missing-mond-data ]**
  **[ \--evac-mode ]**
  **[ \--restricted-migration ]**
@@ -463,6 +464,10 @@ The options that can be passed to the program are as 
follows:
    If given, also query Xen-specific collectors from MonD, provided
    that monitoring daemons are queried at all.
+\--mond-kvm-rss
+  If given, also query the residual set size for kvm instances, provided
+  that monitoring daemons are queried at all.
+
  \--exit-on-missing-mond-data
    If given, abort if the data obtainable from querying MonDs is incomplete.
    The default behavior is to continue with a best guess based on the static
diff --git a/src/Ganeti/HTools/Program/Hbal.hs 
b/src/Ganeti/HTools/Program/Hbal.hs
index e2efa57..4c2c9c9 100644
--- a/src/Ganeti/HTools/Program/Hbal.hs
+++ b/src/Ganeti/HTools/Program/Hbal.hs
@@ -112,6 +112,7 @@ options = do
      , oMonDDataFile
      , oMonDExitMissing
      , oMonDXen
+    , oMonDKvmRSS
      , oExTags
      , oExInst
      , oSaveCluster

Reply via email to