Actually, I want to submit an interdiff:
diff --git a/src/Ganeti/Metad/WebServer.hs b/src/Ganeti/Metad/WebServer.hs
index d47ab52..1671ddf 100644
--- a/src/Ganeti/Metad/WebServer.hs
+++ b/src/Ganeti/Metad/WebServer.hs
@@ -184,7 +184,7 @@ handleMetadata params GET "ganeti" "latest" paramPath
| isParamPath paramPath =
[_, _, param] -> do
remoteAddr <- ByteString.unpack . rqRemoteAddr <$> getRequest
instanceParams <- liftIO $ do
- Logging.logInfo $ "OS package for " ++ show remoteAddr
+ Logging.logInfo $ "OS param " ++ param ++ " for " ++ show
remoteAddr
readMVar params
serveSingleOsParam remoteAddr instanceParams param
`catchError`
On Fri, Oct 23, 2015 at 4:47 PM, Klaus Aehlig <[email protected]> wrote:
> On Fri, Oct 23, 2015 at 04:37:45PM +0200, 'Hrvoje Ribicic' via
> ganeti-devel wrote:
> > The only way we provide OS params to metadata daemon clients is
> > through a JSON file containing a lot of data. This patch exposes
> > individual parameters in a RESTful way, making it easier to actually
> > use the metadata daemon.
> >
> > Signed-off-by: Hrvoje Ribicic <[email protected]>
> > ---
> > doc/design-os.rst | 5 +++++
> > src/Ganeti/Metad/Config.hs | 9 ++++++---
> > src/Ganeti/Metad/WebServer.hs | 31 +++++++++++++++++++++++++++++++
> > 3 files changed, 42 insertions(+), 3 deletions(-)
>
> LGTM
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
>
Hrvoje Ribicic
Ganeti Engineering
Google Germany GmbH
Dienerstr. 12, 80331, München
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.
