On Wed, Oct 28, 2015 at 11:56:57AM +0100, 'Helga Velroyen' via ganeti-devel
wrote:
> This fixes the fact that the last patch was submitted
> in the wrong version. It also fixes a bug where
> accidentally the node was not looked up properly
> in the ssh_port_map.
>
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
> lib/backend.py | 7 ++-----
> lib/cmdlib/cluster/verify.py | 16 +++-------------
> lib/cmdlib/node.py | 6 +-----
> lib/rpc_defs.py | 4 ----
> lib/server/noded.py | 5 ++---
> test/py/ganeti.backend_unittest.py | 4 ++--
> 6 files changed, 10 insertions(+), 32 deletions(-)
> --- a/lib/rpc_defs.py
> +++ b/lib/rpc_defs.py
> @@ -513,7 +513,6 @@ _NODE_CALLS = [
> ("checkdict", None, "What to verify"),
> ("cluster_name", None, "Cluster name"),
> ("all_hvparams", None, "Dictionary mapping hypervisor names to
> hvparams"),
> - ("node_groups", None, "node names mapped to their group uuids"),
> ], None, None, "Request verification of given parameters"),
> ("node_volumes", MULTI, None, constants.RPC_TMO_FAST, [], None, None,
> "Gets all volumes on node(s)"),
> @@ -681,9 +680,6 @@ CALLS = {
> ("checkdict", None, "What to verify"),
> ("cluster_name", None, "Cluster name"),
> ("hvparams", None, "Dictionary mapping hypervisor names to hvparams"),
> - ("node_groups", None, "node names mapped to their group uuids"),
> - ("groups_cfg", None,
> - "a dictionary mapping group uuids to their configuration"),
> ], None, None, "Request verification of given parameters"),
> ]),
> "RpcClientConfig": _Prepare([
This change looks as if you were changing the rpc interface. How does this
fit with Ganeti not requiring the save revision within the same minor version?
Thanks,
Klaus
--
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle