On Wed, Oct 28, 2015 at 03:19:36PM +0100, 'Hrvoje Ribicic' via ganeti-devel wrote: > Some instances from very old Ganeti versions may not have any creation > time information embedded in the config. The upgrade code does not > expect this, and crashes horribly when trying to populate newly > separate disk objects with the same creation time, and this patch > fixes things by inserting a fake value: 0. > > The value was chosen because the serialization and deserialization of > such an instance in Haskell yields a value of 0 for the ctime, making > the time consistent between instance and disk. While showing the epoch > time instead of N/A in gnt-instance info is suboptimal, due to the age > of the Ganeti version in which these instances must have been created, > they are at least still ordered correctly. > > Signed-off-by: Gerard Oskamp <[email protected]> > Signed-off-by: Hrvoje Ribicic <[email protected]> > --- > test/data/cluster_config_2.11.json | 1 - > test/py/cfgupgrade_unittest.py | 3 +++ > tools/cfgupgrade | 4 +++- > 3 files changed, 6 insertions(+), 2 deletions(-)
LGTM. Thanks. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
