LGTM
On 11/04/2015 02:06 PM, 'Hrvoje Ribicic' via ganeti-devel wrote:
With particularly large clusters, the SSH renewal of key happening in
renew-crypto can take a long time to complete. While this should be
improved, an additional problem is that the RPC doing most of the work
has a default one-hour timeout. Given that it is preferable that the
operation completes, this patch bumps the timeout to four hours, which
should suffice even for 80+ node clusters.
Signed-off-by: Hrvoje Ribicic <[email protected]>
---
lib/rpc_defs.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rpc_defs.py b/lib/rpc_defs.py
index 7660510..17fa948 100644
--- a/lib/rpc_defs.py
+++ b/lib/rpc_defs.py
@@ -560,7 +560,7 @@ _NODE_CALLS = [
("readd", None,
"Whether this is a readd operation.")],
None, None, "Remove a node's SSH key from the other nodes' key files."),
- ("node_ssh_keys_renew", MULTI, None, constants.RPC_TMO_SLOW, [
+ ("node_ssh_keys_renew", MULTI, None, constants.RPC_TMO_4HRS, [
("node_uuids", None, "UUIDs of the nodes whose key is renewed"),
("node_names", None, "Names of the nodes whose key is renewed"),
("master_candidate_uuids", None, "List of UUIDs of master candidates."),
