LGTM, thanks On Fri, 13 Nov 2015 at 11:18 'Hrvoje Ribicic' via ganeti-devel < [email protected]> wrote:
> These tests deal with large configuration files, and without the > changes present in this patch, instead of a pretty git-style diff of > two configurations, we get nothing. > > Signed-off-by: Hrvoje Ribicic <[email protected]> > --- > test/py/cfgupgrade_unittest.py | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/py/cfgupgrade_unittest.py > b/test/py/cfgupgrade_unittest.py > index 3f587662..a6dec64 100755 > --- a/test/py/cfgupgrade_unittest.py > +++ b/test/py/cfgupgrade_unittest.py > @@ -118,6 +118,10 @@ def _RunUpgrade(path, dry_run, no_verify, > ignore_hostname=True, > > class TestCfgupgrade(unittest.TestCase): > def setUp(self): > + # Since we are comparing large dictionaries here, this is vital to > getting > + # useful feedback about differences in config content using > assertEquals. > + self.maxDiff = None > + > self.tmpdir = tempfile.mkdtemp() > > self.config_path = utils.PathJoin(self.tmpdir, "config.data") > -- > 2.6.0.rc2.230.g3dd15c0 > > -- Helga Velroyen Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
