Sorry for commenting on the first patch, more to follow: On Tue, Nov 10, 2015 at 3:56 PM, 'Oleg Ponomarev' via ganeti-devel < [email protected]> wrote:
> Implement ppost_hooks_exec.py which has already been reffered from > forkPostHooksProcess. This python process will be used in order to > run global POST hooks for opcodes which processes have disappeared. > > Signed-off-by: Oleg Ponomarev <[email protected]> > --- > lib/jqueue/post_hooks_exec.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/jqueue/post_hooks_exec.py b/lib/jqueue/post_hooks_exec.py > index e6a215f..81ab58d 100644 > --- a/lib/jqueue/post_hooks_exec.py > +++ b/lib/jqueue/post_hooks_exec.py > @@ -98,8 +98,8 @@ def main(): > hm = HooksMaster(target_op.input.OP_ID, None, > ([], [cfg.GetMasterNodeName()]), > context.GetRpc(cfg).call_hooks_runner, > - RpcResultsToHooksResults, None, None, None, > - logging.warning, cfg.GetClusterName(), > + RpcResultsToHooksResults, None, None, > + logging.warning, None, cfg.GetClusterName(), > cfg.GetMasterNodeName(), job_id) > Consider adding a helper function to hooksmaster.py instead of explicitly invoking this constructor. > hm.RunPhase(constants.HOOKS_PHASE_POST, True, > constants.POST_HOOKS_STATUS_DISAPPEARED) > -- > 2.6.0.rc2.230.g3dd15c0 > > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
