Good catch! I'll resend the patch soon. On Wed, 18 Nov 2015 at 11:20 Lisa Velden <[email protected]> wrote:
> Isn't that function the same as copy() for a dictionary? Besides, as far > as I can tell the referenced bug talks about instance methods, not lists > and there is actually a test for deepcopy with lists inside dicts: > https://hg.python.org/cpython/file/default/Lib/test/test_copy.py#l362. > > On Wed, Nov 18, 2015 at 11:06 AM 'Klaus Aehlig' via ganeti-devel < > [email protected]> wrote: > >> On Wed, Nov 18, 2015 at 10:30:41AM +0100, 'Helga Velroyen' via >> ganeti-devel wrote: >> > Due to a bug in python, deepcopy does not work on >> > dictionaries with lists as values. This patch adds >> > a workaround function to utils and uses them when >> > in the functions updating SSH keys. >> > >> > Signed-off-by: Helga Velroyen <[email protected]> >> > --- >> > lib/backend.py | 5 ++--- >> > lib/utils/algo.py | 21 +++++++++++++++++++++ >> > 2 files changed, 23 insertions(+), 3 deletions(-) >> >> LGTM >> >> -- >> Klaus Aehlig >> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle >> > -- > Lisa Velden > Software Engineer > [email protected] > > Google Germany GmbH > Dienerstraße 12 > 80331 München > > Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > -- Helga Velroyen Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
