LGTM On Thu, Nov 19, 2015 at 2:33 PM 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> Commit c22a35 removed an argument of readJSONWithDesc which > caused some versions of ghc to go too crazy in optimising, > so it had to be turned off for some files. Document that reason > in a comment. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/Objects/Instance.hs | 2 ++ > src/Ganeti/OpCodes.hs | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/src/Ganeti/Objects/Instance.hs > b/src/Ganeti/Objects/Instance.hs > index e312983..fb35f65 100644 > --- a/src/Ganeti/Objects/Instance.hs > +++ b/src/Ganeti/Objects/Instance.hs > @@ -1,5 +1,7 @@ > {-# LANGUAGE TemplateHaskell, FunctionalDependencies #-} > {-# OPTIONS_GHC -O0 #-} > +-- We have to disable optimisation here, as some versions of ghc otherwise > +-- fail to compile this code, at least within reasonable memory limits > (40g). > > {-| Implementation of the Ganeti Instance config object. > > diff --git a/src/Ganeti/OpCodes.hs b/src/Ganeti/OpCodes.hs > index c6ffa5d..8e4f7c0 100644 > --- a/src/Ganeti/OpCodes.hs > +++ b/src/Ganeti/OpCodes.hs > @@ -1,5 +1,7 @@ > {-# LANGUAGE ExistentialQuantification, TemplateHaskell, > StandaloneDeriving #-} > {-# OPTIONS_GHC -fno-warn-orphans -O0 #-} > +-- We have to disable optimisation here, as some versions of ghc otherwise > +-- fail to compile this code, at least within reasonable memory limits > (40g). > > {-| Implementation of the opcodes. > > -- > 2.6.0.rc2.230.g3dd15c0 > > -- Lisa Velden Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
