LGTM, thanks.

On Thu, 19 Nov 2015 at 14:05 'Hrvoje Ribicic' via ganeti-devel <
[email protected]> wrote:

> As more and more configuration values will have to be made available via
> queries, this patch adds a small helper method for these.
>
> Signed-off-by: Hrvoje Ribicic <[email protected]>
> ---
>  src/Ganeti/Query/Server.hs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs
> index 5d39110..e2d770a 100644
> --- a/src/Ganeti/Query/Server.hs
> +++ b/src/Ganeti/Query/Server.hs
> @@ -374,8 +374,8 @@ handleCall _ _ cfg (QueryNetworks names fields lock) =
>      (map Left names) fields lock
>
>  handleCall _ _ cfg (QueryConfigValues fields) = do
> -  let params = [ ("cluster_name", return . showJSON . clusterClusterName
> -                                    . configCluster $ cfg)
> +  let clusterProperty fn = showJSON . fn . configCluster $ cfg
> +  let params = [ ("cluster_name", return $ clusterProperty
> clusterClusterName)
>                 , ("watcher_pause", liftM (maybe JSNull showJSON)
>                                       QCluster.isWatcherPaused)
>                 , ("master_node", return . genericResult (const JSNull)
> showJSON
> --
> 2.1.4
>
> --

Helga Velroyen
Software Engineer
[email protected]

Google Germany GmbH
Dienerstraße 12
80331 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

Reply via email to