LGTM On Fri, Nov 20, 2015 at 10:01 PM 'Oleg Ponomarev' via ganeti-devel < [email protected]> wrote:
> This is the fix for the issue 1144. The nodes affected by the > InstanceChangeGroup logical unit were calculated incorrectly and that > broke 'gnt-instance change-group --to' operation. This patch fixes it. > > Signed-off-by: Oleg Ponomarev <[email protected]> > --- > lib/cmdlib/instance.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cmdlib/instance.py b/lib/cmdlib/instance.py > index 4e5d191..9fc14d4 100644 > --- a/lib/cmdlib/instance.py > +++ b/lib/cmdlib/instance.py > @@ -4137,7 +4137,7 @@ class LUInstanceChangeGroup(LogicalUnit): > self._LockInstancesNodes() > > # Lock all nodes in all potential target groups > - lock_groups = > (frozenset(self.owned_locks(locking.LEVEL_NODEGROUP)) - > + lock_groups = > (frozenset(self.owned_locks(locking.LEVEL_NODEGROUP)) | > > self.cfg.GetInstanceNodeGroups(self.op.instance_uuid)) > member_nodes = [node_uuid > for group in lock_groups > -- > 2.6.0.rc2.230.g3dd15c0 > > -- Lisa Velden Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
