On Tue, Nov 24, 2015 at 5:18 PM, Oleg Ponomarev <[email protected]> wrote:
> On 11/24/2015 05:06 PM, Hrvoje Ribicic wrote: > >> One possible improvement: we can consider asserting that all node_uuids >> passed are truly uuids whenever RunPhase is invoked. Or do you think this >> is too paranoid? >> >> > I am not sure that it worth it because it will break several tests which > use node names like "a" or still use names. Also passing node names is not > that critical because rpc runner can deal with them. > Since tests should reflect real use cases, they should probably be changed as a part of this patch as well. Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
