LGTM, thanks.
On 12/14/2015 03:17 PM, 'Lisa Velden' via ganeti-devel wrote:
Name the instance where disks are already attached to, which is not
necessarily the instance where we want to attach a disk to.
This fixes issue 1151.
Signed-off-by: Lisa Velden <[email protected]>
---
src/Ganeti/WConfd/ConfigModifications.hs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Ganeti/WConfd/ConfigModifications.hs
b/src/Ganeti/WConfd/ConfigModifications.hs
index aead178..46686d4 100644
--- a/src/Ganeti/WConfd/ConfigModifications.hs
+++ b/src/Ganeti/WConfd/ConfigModifications.hs
@@ -303,7 +303,7 @@ attachInstanceDiskChecks uuidInst uuidDisk idx' cs = do
let insts = M.elems . fromContainer . configInstances . csConfigData $ cs
forM_ insts (\inst' -> when (uuidDisk `elem` instDisks inst') . Bad
. ReservationError $ printf "Disk %s already attached to instance %s"
- uuidDisk (show . fromMaybe "" $ instName inst))
+ uuidDisk (show . fromMaybe "" $ instName inst'))
-- * Pure config modifications functions
