On Wed, Dec 02, 2015 at 02:35:42PM +0200, Apollon Oikonomopoulos wrote:
> Commit cc8a8ed7 outlined the reasons for configuring bridged NICs early
> during live migration and routed NICs after migration has been finished.
> Back then these were the only types of NICs available, however with the
> introduction of OVS support this has changed.
> 
> Since OVS bridges are essentially bridges, the considerations outlined
> in cc8a8ed7 still apply: in particular, we do not want to lose the
> gratuitous ARP sent out by the KVM NICs, so we have to configure
> the OVS interfaces early in the migration process as well.
> 
> Rather than explicitly configure bridged and OVS interfaces early, we
> prefer to explicitly configure routed interfaces late, since this leads
> to more compact code.
> 
> Signed-off-by: Apollon Oikonomopoulos <[email protected]>
> ---
>  lib/hypervisor/hv_kvm.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle

Reply via email to