On Tue, 12 Jan 2016 at 14:02 'Klaus Aehlig' via ganeti-devel <
[email protected]> wrote:

> Cluster upgrades to a new minor version of Ganeti are a rare
> operation (in fact, new minor versions are released only every
> 3 months). Therefore, we do not have to worry, about increased
>

remove comma behind 'worry'


> size of log files. However, upgrades of Ganeti are complicated
> in the sense that, should something break during the upgrade, it
> is not immediately obvious, in which Ganeti is left in. Therefore,
>

in which 'state'?


> always provide full log information on upgrades. Fixes issue 1137.
>
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  lib/client/gnt_cluster.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/client/gnt_cluster.py b/lib/client/gnt_cluster.py
> index f1cabef..bffc163 100644
> --- a/lib/client/gnt_cluster.py
> +++ b/lib/client/gnt_cluster.py
> @@ -2257,6 +2257,8 @@ def UpgradeGanetiCommand(opts, args):
>                   " finish it first" % (oldversion, versionstring))
>          return 1
>
> +  utils.SetupLogging(pathutils.LOG_COMMANDS, 'gnt-cluster upgrade',
> debug=1)



> +
>    oldversion = constants.RELEASE_VERSION
>
>    if opts.resume:
> --
> 2.6.0.rc2.230.g3dd15c0
>
>
LGTM, thanks
-- 

Helga Velroyen
Software Engineer
[email protected]

Google Germany GmbH
Erika-Mann-Strasse 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

Reply via email to