On Tue, Jan 12, 2016 at 04:03:32PM +0100, 'Helga Velroyen' via ganeti-devel wrote: > This patch adds an RPC call, which is a very light-weight > version of removing an SSH key from the cluster. It simply > only removes it from the public key file of the master. > > This is used later to clean up in case the pre-hooks for > adding a node fail. When adding a node with 'gnt-node add', > the client code in gnt_node adds the key to the public > key file. If the hooks fail, so far this key was not > cleaned up and manual intervention was necessary. > > To avoid any abuse of the RPC call, it includes a safety > check which makes sure that only keys of nodes that are > not in the cluster anymore (and thus are stray keys). > > Signed-off-by: Helga Velroyen <[email protected]> > --- > lib/backend.py | 34 +++++++++++++++++++++++++++ > lib/rpc_defs.py | 3 +++ > lib/server/noded.py | 8 +++++++ > test/py/ganeti.backend_unittest.py | 47 > ++++++++++++++++++++++++++++++++++++++ > 4 files changed, 92 insertions(+)
LGTM -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
