LGTM, thanks On Mon, Jan 18, 2016 at 3:29 PM, 'Brian Foley' via ganeti-devel < [email protected]> wrote:
> The code had an incorrect check for instance primary being in the node > group and as a result built a dict of node uuids to lists of LV names > with ~N x duplication in the lists, where N = number of nodes in group. > > Signed-off-by: Brian Foley <[email protected]> > --- > lib/cmdlib/cluster/verify.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cmdlib/cluster/verify.py b/lib/cmdlib/cluster/verify.py > index 800f109..fa7c8e2 100644 > --- a/lib/cmdlib/cluster/verify.py > +++ b/lib/cmdlib/cluster/verify.py > @@ -2184,7 +2184,7 @@ class LUClusterVerifyGroup(LogicalUnit, > _VerifyErrors): > for instance in self.all_inst_info.values(): > for secondary in self.cfg.GetInstanceSecondaryNodes(instance.uuid): > if (secondary in self.my_node_info > - and instance.name not in self.my_inst_info): > + and instance.uuid not in self.my_inst_info): > self.cfg.GetInstanceLVsByNode(instance.uuid, > lvmap=node_vol_should) > break > > -- > 2.6.0.rc2.230.g3dd15c0 > > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
