LGTM, thanks On Wed, 20 Jan 2016 at 12:30 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote:
> ...as this works against the idea of having all constants in one > central place so that they can be changed in a simple way. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > lib/rpc/transport.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/rpc/transport.py b/lib/rpc/transport.py > index 8271016..47f1433 100644 > --- a/lib/rpc/transport.py > +++ b/lib/rpc/transport.py > @@ -70,7 +70,8 @@ class Transport: > There are two timeouts used since we might want to wait for a long > time for a response, but the connect timeout should be lower. > > - If not passed, we use a default of 10 and respectively 60 seconds. > + If not passed, we use the default luxi timeouts from the global > + constants file. > > Note that on reading data, since the timeout applies to an > invidual receive, it might be that the total duration is longer > -- > 2.7.0.rc3.207.g0ac5344 > > -- Helga Velroyen Software Engineer [email protected] Google Germany GmbH Erika-Mann-Strasse 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
