LGTM

On Mon, Jan 25, 2016 at 3:48 PM 'Klaus Aehlig' via ganeti-devel <
[email protected]> wrote:

> Fixing version of some haskell packages while only specifying
> minimal versions for others can result in a combination of
> packages that don't work together (even though they are not
> formally recognised as conflicting). Only specifying minimal
> versions usually pulls in the latest and greatest of every package
> which usually works fine together. In particular, this patch
> fixes the currently broken chroot build for trusty.
>
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  devel/build_chroot | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/devel/build_chroot b/devel/build_chroot
> index 12f6fde..f76888e 100755
> --- a/devel/build_chroot
> +++ b/devel/build_chroot
> @@ -684,19 +684,19 @@ EOF
>         cabal install --global \
>          'base64-bytestring>=1' \
>          'happy>=1.19' \
> -        hslogger-1.2.3 \
> +        'hslogger-1.2.3' \
>          'hlint>=1.9.12' \
> -        json-0.7 \
> -        lens-3.10.2 \
> +        'json-0.7' \
> +        'lens-3.10.2' \
>          'lifted-base>=0.1.2' \
>          'network>=2.4.0.1' \
>          'regex-pcre>=0.94.4' \
> -        parsec-3.1.3 \
> +        'parsec-3.1.3' \
>          shelltestrunner \
>          'snap-server>=0.8.1' \
> -        test-framework-0.8.0.3 \
> -        test-framework-hunit-0.3.0.1 \
> -        test-framework-quickcheck2-0.3.0.2 \
> +        'test-framework-0.8.0.3' \
> +        'test-framework-hunit-0.3.0.1' \
> +        'test-framework-quickcheck2-0.3.0.2' \
>          'transformers>=0.3.0.0' \
>          zlib-0.5.4.2
>      ;;
> @@ -744,21 +744,21 @@ EOF
>      in_chroot -- \
>         cabal install --global -j \
>          'base64-bytestring>=1' \
> -        hslogger-1.2.3 \
> +        hslogger>=1.2.3 \
>          'hlint>=1.9.12' \
> -        json-0.7 \
> -        lens-3.10.2 \
> +        json>=0.7 \
> +        lens>=3.10.2 \
>          'lifted-base>=0.1.2' \
>          'network>=2.4.0.1' \
>          'regex-pcre>=0.94.4' \
> -        parsec-3.1.3 \
> +        parsec>=3.1.3 \
>          shelltestrunner \
>          'snap-server>=0.8.1' \
> -        test-framework-0.8.0.3 \
> -        test-framework-hunit-0.3.0.1 \
> -        test-framework-quickcheck2-0.3.0.2 \
> +        test-framework>=0.8.0.3 \
> +        test-framework-hunit>=0.3.0.1 \
> +        test-framework-quickcheck2>=0.3.0.2 \
>          'transformers>=0.3.0.0' \
> -        zlib-0.5.4.2
> +        zlib>=0.5.4.2
>      ;;
>
>
> --
> 2.7.0.rc3.207.g0ac5344
>
> --
Lisa Velden
Software Engineer
[email protected]

Google Germany GmbH
Erika-Mann-Straße 33
80636 München


Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Reply via email to