On Thu, Feb 04, 2016 at 05:48:39PM +0000, 'Brian Foley' via ganeti-devel wrote:
> Actually print the Distribution.Simple.Configure error message on
> failure rather than throwing it on the floor.
>
> Signed-off-by: Brian Foley <[email protected]>
> ---
> cabal/CabalDependenciesMacros.hs | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/cabal/CabalDependenciesMacros.hs
> b/cabal/CabalDependenciesMacros.hs
> index e07def7..0b6a098 100644
> --- a/cabal/CabalDependenciesMacros.hs
> +++ b/cabal/CabalDependenciesMacros.hs
> @@ -3,7 +3,7 @@ module Main where
> import Control.Applicative
> import qualified Data.Set as Set
> import qualified Distribution.Simple.Build.Macros as Macros
> -import Distribution.Simple.Configure (maybeGetPersistBuildConfig)
> +import Distribution.Simple.Configure (tryGetPersistBuildConfig)
NACK.
This requires a newer version of this module, which is not present
in all linux distributions we care about.
While it is OK to insist on newer packages on master (and only on
master) such a restriction of supported versions has to be properly
documented ("New dependencies" entry in NEWS, constraints in
cabal/ganeti.template.cabal).
Note that I in general like the idea of better error reporting,
but this should not come at the price of breaking existing builds.
--
Klaus Aehlig
Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
