Thank you both for cleaning up the patch and reviewing it! I'll submit shortly.
On Tue, Sep 13, 2016 at 3:58 PM, 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote: > On Tue, Sep 13, 2016 at 03:28:06PM +0100, 'Federico Morg Pareschi' via > ganeti-devel wrote: > > This is just a partial implementation of the static lock prediction > system. > > With this, Ganeti queue system tries to predict the locks of the running > > jobs and schedule new jobs that are less likely to block. > > It is a partial implementation which might cause starvation for jobs > stuck > > in the queue, following patches will address this issue. > > > > Signed-off-by: Federico Morg Pareschi <[email protected]> > > --- > > src/Ganeti/Config.hs | 1 + > > src/Ganeti/Constants.hs | 27 ++ > > src/Ganeti/JQScheduler.hs | 26 +- > > src/Ganeti/JQueue.hs | 1 + > > src/Ganeti/JQueue/LockDecls.hs | 591 ++++++++++++++++++++++++ > > src/Ganeti/Objects.hs | 1 - > > test/hs/Test/Ganeti/JQueue/LockDecls.hs | 150 ++++++ > > test/hs/Test/Ganeti/Objects.hs | 30 +- > > test/hs/Test/Ganeti/OpCodes.hs | 777 > ++++++++++++++++---------------- > > test/hs/Test/Ganeti/TestCommon.hs | 2 +- > > test/hs/htest.hs | 2 + > > 11 files changed, 1215 insertions(+), 393 deletions(-) > > create mode 100644 src/Ganeti/JQueue/LockDecls.hs > > create mode 100644 test/hs/Test/Ganeti/JQueue/LockDecls.hs > > LGTM, thanks. > > -- > Klaus Aehlig > Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle >
