On 2016-10-01 23:18:59, Ganeti Development List wrote: > On Sat, Oct 01, 2016 at 11:40:47PM +0200, Iustin Pop wrote: > > On 2016-10-01 19:55:30, Robin H. Johnson wrote: > > > If you're running pylint on jessie as you say, then it's a really old > > > pylint, > > > so I suspect much of this may just be newer checks then. I did think > > > jessie-backports had a relatively modern pylint however. > > > > Some historical context: this is not about jessie being old, it's the > > fact that Ganeti depends on an exact pylint version. > > > > Pylint checks change significantly between versions (sometimes even for > > minor versions), so one cannot do automated checks at commit time unless > > the checks are stable; hence the requirement for an exact version, and > > not what the current distro has, so that all devs see the same output as > > buildbot/commit checks. > > > > It would be very good if someone spent the time to cleanup the codebase > > and bump up the pylint version, but as I see it from your output it's a > > lot of style changes (of almost no value) instead of actual Python > > fixes. > > That said, when the codebase doesn't trigger lots of spurious warnings, > pylint is good at picking up errors (variable name typos etc) that it's > all too easy to make with Python. It's almost like having a compiler! :-P
Correct, it's the closest thing to that in Python, and it is indeed very useful. I just wished that it is more stable. > I wouldn't mind investing some effort into a mix of turning off newer > pylint messages if we think they're unhelpful, and fixing the rest. I don't think they need turning off; I guess most likely there are more granular indentation/style settings, which need to be set according to Ganeti's style; presuming, of course, that for those new things (e.g. hanging continuations after '|' , etc.) the style is consistent throughout the codebase :) regards, iustin
