On Fri, Oct 07, 2016 at 08:38:00PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > Migration is supported on KVM/Xen hypervisors only. Finalize methods are > called in both success or suspected failure (the master node can't > certainly know about failures - e.g. in case of timeouts). Thus these > functions need to be as robust as possible in order to be able to > recover from failures - in case success=False the functions should be > conservative, trying to detect the actual state and idempotent.
LGTM, thanks. This should make Xen migrates a lot more robust.
