I wouldn't mind backporting up to 2.16, since we haven't released stable (yet).
On Tue, Nov 29, 2016 at 9:59 AM, 'Federico Pareschi' via ganeti-devel < [email protected]> wrote: > I also think that originally this behavior was intentional, however it is > very non-intuitive to me (and otheres) > and it seems to introduce unexpected behavior so it's probably better if > we get rid of it. > > I would put this in master because it breaks user-facing behaviors, should > this be backported to 2.17 maybe? > > Morg. > > > On Monday, November 28, 2016 at 10:56:05 PM UTC, Iustin Pop wrote: >> >> On 2016-11-28 14:10:39, Ganeti Development List wrote: >> > From the modified log line it looks like it was intentional, but as we >> > discussed I don't see a good reason for this. Reinstalling OS image >> without >> > changing the configuration creates an inconsistency between the state >> of >> > the world and state of record and we want to _always_ minimise this. >> >> The current way would allow reinstalling an instance without changing >> the parameters (for whatever reason); it's always possible to change >> first and then reinstall if things needs to be kept in sync. >> >> Not saying this makes sense, just that it might be the reason behind it. >> The commit message (83f54ca) doesn't mention anything. >> >> > Also >> > is it happening only on master ? Other than that LGTM. >> >> It was introduced in 2.12 beta 1, so somewhat old. Might need a NEWS >> file entry for changed behaviour. >> >> regards, >> iustin >> >
