Aside from the couple of nitpicks that I've already commented in the rest of the patchset, this looks like a reasonable patch to me.
I haven't had the time to test it yet, but other than that it looks good to me. On 1 December 2016 at 10:34, Yiannis Tsiouris <[email protected]> wrote: > This patchset extends 'gnt-instance modify' and 'gnt-instance reinstall' > functionality by allowing partial/total removal of current OS parameters > of an > instance. This is specifically useful for preparing or performing an > instance > reinstall to a different OS provider or the same OS provider that changed > its > OS parameter policy/supported list. > > Nikos Skalkotos (1): > Add cmdlib tests for removing instance OS params > > Yiannis Tsiouris (5): > Add clear OS params options in gnt-instance modify > Support OS params removal in gnt-instance modify > Test new options of gnt-instance modify in RAPI > Support clear OS params in gnt-instance reinstall > Add OS params removal in gnt-instance reinstall > > lib/cli_opts.py | 32 +++++++++++++++ > lib/client/gnt_instance.py | 44 +++++++++++++++++++-- > lib/cmdlib/instance_operation.py | 16 ++++++++ > lib/cmdlib/instance_set_params.py | 45 ++++++++++++++++++++- > lib/rapi/rlib2.py | 16 +++++++- > man/gnt-instance.rst | 25 ++++++++++++ > src/Ganeti/HTools/Repair.hs | 8 ++++ > src/Ganeti/OpCodes.hs | 8 ++++ > src/Ganeti/OpParams.hs | 48 +++++++++++++++++++++++ > test/hs/Test/Ganeti/OpCodes.hs | 7 ++++ > test/py/cmdlib/instance_unittest.py | 36 +++++++++++++++++ > test/py/ganeti.rapi.rlib2_unittest.py | 73 +++++++++++++++++++++--------- > ----- > 12 files changed, 325 insertions(+), 33 deletions(-) > > -- > 2.10.2 > >
