No problem, thanks again for the reviews :) This commit has been pushed in master @ e763a23a339670110df279c900a052b64323c783
On Friday, December 16, 2016 at 3:18:52 PM UTC, Brian Foley wrote: > > On Fri, Dec 16, 2016 at 03:00:41PM +0000, 'Federico Morg Pareschi' via > ganeti-devel wrote: > > This commit improves some of the test data generation in the ConfigData > > dummy values of quickcheck. It generates more realistic instance, node > > and group names by sampling them from the provided ConfigData. This > > makes it possible to test for consistent data validation that might > > depend on multiple names being present in the cluster configuration at > > the same time. > > > > Signed-off-by: Federico Morg Pareschi <[email protected]> > > LGTM. Feel free to submit. Thanks, and sorry again for the slow review. > > Cheers, > Brian. >
