I have a few suggestions for the rpm packages: First, for the ganglia-webfrontend package, I like that this package is relocatable, but could the "ganglia-webfrontend" part of the path be moved to the default prefix instead of being a mandatory part of the installation path? This way, when I install the rpm with the --prefix option to relocate it, I can pick the exact directory I want to install the files into. Right now I have no choice and everything goes into a "ganglia-webfrontend" sub-directory of the prefix that I specify. Could source rpms for this package also be made available, or maybe the spec file included in the tarball?
Second, for the ganglia-monitor-core spec file, I would suggest adding the noreplace option to the two config files in the file list, in case you don't know since rpm is very poorly documented, you do it like: %config(noreplace) /etc/gmetad.conf This way, when upgrading ganglia, rpm will not rename your modified config file to .rpmsave. I believe this would only happen if the new package comes with a new version of the config file, but it is better to be safe and not replace a config file that has been customized. With the noreplace option, rpm will just install the new version of the config file with .rpmnew appended to the filename. Also, for the post scripts I would move the /sbin/chkconfig --add command outside of the if statement since it will then guarantee that it is added to the appropriate run-levels during package installs and upgrades. Since the priority has changed for gmond, it might actually be better to execute chkconfig with the reset command instead of --add since this will force it to remake all of the symlinks, even if they are already there. The last comment I have is that currently the daemons are not restarted during a package upgrade. In packages that I make, I usually put it all in the post script, instead of the postun script. I would suggest doing something like this to fix both of these problems: %post gmond /sbin/chkconfig gmond reset if [ "$1" -eq "1" ]; then # Installing new package - start gmond: /etc/rc.d/init.d/gmond start elif [ "$1" -gt "1" ]; then # Upgrading ganglia package - restart gmond: /etc/rc.d/init.d/gmond restart fi Comments/suggestions? ~Jason -- /------------------------------------------------------------------\ | Jason A. Smith Email: [EMAIL PROTECTED] | | Atlas Computing Facility, Bldg. 510M Phone: (631)344-4226 | | Brookhaven National Lab, P.O. Box 5000 Fax: (631)344-7616 | | Upton, NY 11973-5000 | \------------------------------------------------------------------/
