While getting rid of libdnet solved one class of include problems, a new
one has been created.  Specificly, you can not build ganglia if it is
already installed because we include <ganglia.h> and the include order
(in the case of gmetad) is:

-I. -I. -I.. ${CPPFLAGS} -I../lib -I../gmond

Since CPPFLAGS will often contan the directory the old version of
ganglia is installed in which causes problems like:

gcc -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/local/include -O0 -I../lib
-I../gmond -g -O2 -Wall -c `test -f 'conf.c' || echo './'`conf.c
conf.c: In function `cb_trusted_hosts':
conf.c:59: error: `MAXHOSTNAME' undeclared (first use in this function)
conf.c:59: error: (Each undeclared identifier is reported only once
conf.c:59: error: for each function it appears in.)
conf.c: In function `cb_data_source':
conf.c:131: error: `MAXHOSTNAME' undeclared (first use in this function)

I think the easiest solution is probably to get rid of the <ganglia.h>
includes in favor of ether <lib/ganglia.h> includes which would work
with the -I.. or "../lib/ganglia.h" includes that bypass the -I setting
entierly.  The other alternative is to require that libganglia be
installed before building gmond and gmetad which would require changes
to the build system.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

Attachment: pgphvwl6TJbyW.pgp
Description: PGP signature

Reply via email to