On Mon, Feb 23, 2004 at 04:50:35PM -0800, Matt Massie wrote: > i just updated CVS and created a new 2.5.7 tarball > (http://matt-massie.com/ganglia/). > > i THINK i've fixed the include path madness. i removed all AM_CFLAGS > specified in Makefile.am and instead explicitly wrote out the paths. > > for example, before we had > > #include "ganglia.h" > > but now it's > > #include "lib/ganglia.h" > > since . and .. are the first places looked it will always find the > ganglia.h in the distribution instead of a ganglia.h that is already > installed (from a previous version). > > thanks brooks for the feedback.
This fixes the problem. Thanks! > i've changed gmond to open two separate XML ports. one compressed > (8649) and one uncompressed (8650). this will prevent any old ganglia > tools from breaking and give us compression without needing to turn it > on with a configuration file everywhere. Two comments. First, have you considered registering these ports (or at least 8650) with IANA? That would help avoid the possibility of collisions with future services. Second, I haven't looked at the wire format so you may be doing this already, but I would recommend that you tag the beginning of the compressed stream with a compression format and possibly allow the client to request a specific format. That would make it easier to add new formats later if desired. I suggest this because while LZ does a very good job of compressing XML, I've heard that compressors with a little knowledge of the DTD can often do better with less CPU. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
pgpxMgTGSvNYF.pgp
Description: PGP signature
