Hi Seth,
thanks. I will take this one before 3.0.2.
Someone else hinted that your pidfile stuff may have problems when a
pidfile without a process exists. I haven't checked myself. do you have
any comments?
Cheers
Martin
--- Seth Alves <[EMAIL PROTECTED]> wrote:
>
> Hello, here is a patch to my last patch.
>
> I set the umask to be too restrictive, and then left it. When gmetad
>
> tries to make new directories, they come out like this:
>
> drw-r--r-x __SummaryInfo__/
>
> and then it can't write new files into them.
>
> -seth
>
>
> --- daemon_init.c 2005-10-27 14:19:07.609392857 -0700
> +++ daemon_init.c-patched 2005-10-27 14:18:56.368240894 -0700
> @@ -27,6 +27,7 @@
> update_pidfile (char *pidfile)
> {
> pid_t pid;
> + mode_t prev_umask;
> FILE *file;
>
> /* make sure this program isn't already running. */
> @@ -43,7 +44,7 @@
> }
>
> /* write the pid of this process to the pidfile */
> - umask(0112);
> + prev_umask = umask (0112);
> unlink(pidfile);
>
> file = fopen (pidfile, "w");
> @@ -55,6 +56,7 @@
> }
> fprintf (file, "%d\n", (int) getpid());
> fclose (file);
> + umask (prev_umask);
> }
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc.
> Get Certified Today * Register for a JBoss Training Course
> Free Certification Exam for All Training Attendees Through End of
> 2005
> Visit http://www.jboss.com/services/certification for more
> information
> _______________________________________________
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
>
>
------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www: http://www.knobisoft.de
