Hi Bernard, as far as I remember, there has been no more discussion on the topic. Making the units configurable would definitely be an option, but I think that is 3.1 material.
Cheers Martin ------------------------------------------------------ Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de ----- Original Message ---- > From: Bernard Li <[EMAIL PROTECTED]> > To: Martin Knoblauch <[EMAIL PROTECTED]> > Cc: Caleb Epstein <[EMAIL PROTECTED]>; > ganglia-developers@lists.sourceforge.net > Sent: Saturday, November 17, 2007 3:22:12 AM > Subject: Re: [Ganglia-developers] Patch to graph.php for bits/sec in network > graphs > > Caleb, Martin: > > Any more discussions regarding this? If not, I would probably just > leave it as is and close the ticket (unless there is a strong reason > to switch). > > P.S. How about having a configuration parameter to switch between > the > two? > > Cheers, > > Bernard > > On 11/2/07, Martin Knoblauch wrote: > > > > Hi, > > > > not sure here. I personally view bytes_in/_out as data > throughput, > where Bytes/sec makes more sese. > > > > Cheers > > Martin > > > > ------------------------------------------------------ > > > > Martin Knoblauch > > > > email: k n o b i AT knobisoft DOT de > > > > www: http://www.knobisoft.de > > > > > > > > ----- Original Message ---- > > > > From: Caleb Epstein > > > > To: ganglia-developers@lists.sourceforge.net > > > > Sent: Friday, November 2, 2007 9:52:18 PM > > > > Subject: [Ganglia-developers] Patch to graph.php for bits/sec > in > network graphs > > > > > > > > Attached patch to ganglia-3.0.5 causes the network graphs to > be > rendered as bits/sec instead of bytes/sec. > > > > > > > > Seeing as network capacties are usually measured in bits/sec, > this > seems like a sensible default. > > > > > > > > -- > > > > Caleb Epstein > > > > > > > > -----Inline Attachment Follows----- > > > > > > > > diff -ur > ganglia-3.0.5/web/graph.php > /pub/www/monitor/ganglia/graph.php > > > > --- ganglia-3.0.5/web/graph.php 2007-10-03 > 00:48:43.000000000 > -0400 > > > > +++ /pub/www/monitor/ganglia/graph.php > 2007-11-02 > 16:26:50.880590000 -0400 > > > > @@ -217,12 +217,14 @@ > > > > > > > > $lower_limit = "--lower-limit 0 --rigid"; > > > > $extras = "--base 1024"; > > > > - $vertical_label = "--vertical-label 'Bytes/sec'"; > > > > + $vertical_label = "--vertical-label 'bits/sec'"; > > > > > > > > $series > = > "DEF:'bytes_in'='${rrd_dir}/bytes_in.rrd':'sum':AVERAGE " > > > > > ."DEF:'bytes_out'='${rrd_dir}/bytes_out.rrd':'sum':AVERAGE " > > > > - ."LINE2:'bytes_in'#$mem_cached_color:'In' " > > > > - ."LINE2:'bytes_out'#$mem_used_color:'Out' "; > > > > + ."CDEF:'bits_in'='bytes_in',8,* " > > > > + ."CDEF:'bits_out'='bytes_out',8,* " > > > > + ."LINE2:'bits_in'#$mem_cached_color:'In' " > > > > + ."LINE2:'bits_out'#$mem_used_color:'Out' "; > > > > } > > > > else if ($graph == "packet_report") > > > > { > > > > @@ -285,6 +287,18 @@ > > > > $rrd_file = "$rrd_dir/$metricname.rrd"; > > > > $series = "DEF:'sum'='$rrd_file':'sum':AVERAGE " > > > > ."AREA:'sum'#$default_metric_color:'$subtitle' "; > > > > + > > > > + // Make network graphs bits/sec > > > > + if ($metricname == "bytes_in" or $metricname == "bytes_out") > > > > + { > > > > + $series = "DEF:'sum'='$rrd_file':'sum':AVERAGE " > > > > + ."CDEF:'bits'='sum',8,* " > > > > + ."AREA:'bits'#$default_metric_color:'$subtitle' "; > > > > + > > > > + $metricname = "network" . substr ($metricname, 5); > > > > + $vertical_label = "--vertical-label 'bits/sec'"; > > > > + } > > > > + > > > > if ($jobstart) > > > > $series .= "VRULE:$jobstart#$jobstart_color "; > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by: Splunk Inc. > > Still grepping through log files to find problems? Stop. > > Now Search log events and configuration files using AJAX and > a > browser. > > Download your FREE copy of Splunk now >> http://get.splunk.com/ > > _______________________________________________ > > Ganglia-developers mailing list > > Ganglia-developers@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/ganglia-developers > > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
