On Wed, Feb 20, 2008 at 12:18:41PM -0800, Bernard Li wrote:
>
> On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote:
>
> > I just committed the fix for the spoofing leak from Martin Hicks. Can you
> > run a [final] snapshot for 3.0.7? I have something brewing to fix the
> > petabyte/sec spikes that one of our customers is seeing, but that needs
> > more testing and can wait for 3.0.8.
>
> The snapshots have been uploaded here:
>
> http://www.ganglia.info/snapshots/3.0.x/
>
> It would be good if we can get folks to ACK the fix.
the fix is throwing this warning at compile time :
gmond.c: In function 'Ganglia_message_save':
gmond.c:840: warning: passing argument 1 of 'xdr_free' from incompatible
pointer type
gmond.c:840: warning: passing argument 2 of 'xdr_free' from incompatible
pointer type
attached patch silences it.
Carlo
Index: gmond/gmond.c
===================================================================
--- gmond/gmond.c (revision 993)
+++ gmond/gmond.c (working copy)
@@ -837,7 +837,7 @@
metric->message.id = metric_user_defined;
metric->message.Ganglia_message_u.gmetric =
message->Ganglia_message_u.spmetric.gmetric;
- xdr_free(xdr_Ganglia_spoof_header,
&message->Ganglia_message_u.spmetric.spheader);
+ xdr_free((xdrproc_t)xdr_Ganglia_spoof_header, (char
*)&(message->Ganglia_message_u.spmetric.spheader));
}else{
memcpy(&(metric->message), message, sizeof(Ganglia_message));
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
