On Thu, Mar 27, 2008 at 3:25 PM, Bernard Li <[EMAIL PROTECTED]> wrote:

> Right now, if you have a grid, by default the first "row" is a summary
>  of the grid represented by load_report and memory_report graphs.  If
>  you click on them, it just goes back to the current page (which is
>  kind of useless).
>
>  I have a patch (currently against 3.0.x, but I will re-base against
>  trunk), that will allow zooming (image size = large) when you click on
>  it.
>
>  This way it is handy to get a large enough images to show yearly
>  summaries of your grids.
>
>  What do you guys think?

It looks like Timothy beat me to it:

http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=184

My patch is bit more involved, but will allow you to simply click on
the graph to zoom in (instead of a '*' which was artificially added):

Index: web/templates/default/meta_view.tpl
===================================================================
--- web/templates/default/meta_view.tpl (revision 1139)
+++ web/templates/default/meta_view.tpl (working copy)
@@ -20,7 +20,24 @@
 </table>
   </TD>

+  <!-- START BLOCK : self_summary_graphs -->
   <TD VALIGN=top align=right>
+  <A HREF="./graph.php?{graph_url}&g=load_report&z=large&r={range}">
+   <IMG SRC="./graph.php?{graph_url}&g=load_report&z=medium&r={range}"
+       ALT="{name} Load" BORDER="0">
+  </A>
+  </TD>
+
+  <TD VALIGN=top>
+  <A HREF="./graph.php?{graph_url}&g=mem_report&z=large&r={range}" VALIGN=top>
+   <IMG SRC="./graph.php?{graph_url}&g=mem_report&z=medium&r={range}"
+       ALT="{name} MEM" BORDER="0">
+  </A>
+  </TD>
+  <!-- END BLOCK : self_summary_graphs -->
+
+  <!-- START BLOCK : summary_graphs -->
+  <TD VALIGN=top align=right>
   <A HREF="{url}">
    <IMG SRC="./graph.php?{graph_url}&g=load_report&z=medium&r={range}"
        ALT="{name} Load" BORDER="0">
@@ -32,7 +49,8 @@
    <IMG SRC="./graph.php?{graph_url}&g=mem_report&z=medium&r={range}"
        ALT="{name} MEM" BORDER="0">
   </A>
-   </TD>
+  </TD>
+  <!-- END BLOCK : summary_graphs -->
 <!-- END BLOCK : public -->

 <!-- START BLOCK : private -->
Index: web/meta_view.php
===================================================================
--- web/meta_view.php   (revision 1139)
+++ web/meta_view.php   (working copy)
@@ -138,6 +138,19 @@
            if(isset($base64img)) {
                 $tpl->assign("base64img", $base64img);
            }
+            if ( $source == $self ) {
+               $tpl->newBlock("self_summary_graphs");
+               $tpl->assign("range", $range);
+               $tpl->assign("name", $name );
+               $tpl->assign("url", $url);
+               $tpl->assign("graph_url", $graph_url);
+            } else {
+               $tpl->newBlock("summary_graphs");
+               $tpl->assign("range", $range);
+               $tpl->assign("name", $name );
+               $tpl->assign("url", $url);
+               $tpl->assign("graph_url", $graph_url);
+            }
          }
       else
          {

Cheers,

Bernard

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to