On Thu, Apr 10, 2008 at 05:51:31PM -0700, Bernard Li wrote:
>
> Index: web/get_context.php
> ===================================================================
> --- web/get_context.php (revision 1139)
> +++ web/get_context.php (working copy)
> @@ -43,14 +43,19 @@
> escapeshellcmd($_GET["z"]) : NULL;
> # A stack of grid parents. Prefer a GET variable, default to cookie.
> if (isset($_GET["gs"]) and $_GET["gs"])
> - $gridstack = explode(":", clean_string( rawurldecode($_GET["gs"] ) ) );
> -else
> - $gridstack = explode(":", clean_string( $_COOKIE["gs"] ) );
> + $gridstack = explode( ">", rawurldecode( $_GET["gs"] ) );
> +else if ( isset($_COOKIE['gs']) and $_COOKIE['gs'])
> + $gridstack = explode( ">", $_COOKIE["gs"] );
>
> +if (isset($gridstack) and $gridstack) {
> + foreach( $gridstack as $key=>$value )
> + $gridstack[ $key ] = clean_string( $value );
> +}
> +
> # Assume we are the first grid visited in the tree if there are no
> CGI variables,
> # or gridstack is not well formed. Gridstack always has at least one element.
> -if (!count($_GET) or !strstr($gridstack[0], "http://";))
> - $initgrid=TRUE;
> +if ( !count($_GET) or !isset($gridstack) or !strstr($gridstack[0],
> "http://";))
> + $initgrid=TRUE;
since the gridstack is also passed around in a cookie the check for the _GET
hash is IMHO bogus and redundant here, since the existence of gridwalk should
be sufficient.
Committed revision 1228
> Since the patch has been modified, I guess we need to re-vote.
+1
Carlo
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
