On Mon, Apr 21, 2008 at 11:48:35AM -0600, Matt Ryan wrote: > > Attached is a patch for this bug. The problem was that with no data > sources providing data to gmetad (since the gmond used as a cluster > collector is down) the internal data structure was empty, and the code > was trying to navigate an empty data structure, hence the 'NoneType' > exception. > > The patch checks for that and does not try to navigate the data > structure if the root node is None. This results in an empty XML > document - the DTD is printed but no other information. Is that > behavior correct?
no, an XML with no body is invalid > If not, let me know what the correct behavior should > be on the XML port if there is no data being collected, and I will > revise. stable gmetad returns an XML with an empty GRID (which I suspect is not correct either) but that the web frontend relies on. <GANGLIA_XML VERSION="3.0.7" SOURCE="gmetad"> <GRID NAME="unspecified" AUTHORITY="http://dell/ganglia/"; LOCALTIME="1208858522"> </GRID> </GANGLIA_XML> an empty GANGLIA_XML (no GRID) makes more sense and is valid, but might break the frontend, and so will require further patches Carlo ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
