What is the status of this patch? Does it need to be proposed for backport?
If so, 3.1.x and 3.0.x?
Brad
>>> On 6/3/2008 at 5:39 AM, in message <[EMAIL PROTECTED]>, Carlo
Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote:
> On Tue, Jun 03, 2008 at 11:36:55AM +0200, Sebastien Piechurski wrote:
>> Here is the same patch made against revision 1373 of the svn repository.
>
> just one minor caveat, for consistency (not that it will make any difference
> though, as the value is overloaded anyway), the default from libgmond should
> match the one from gmond.c and from the embedded configuration (copied
> excerpt
> below from the patch, as it was not possible to reply to your patch directly
> because it was attached and not inlined)
>
> Index: lib/libgmond.c
> ===================================================================
> --- lib/libgmond.c (revision 1375)
> +++ lib/libgmond.c (working copy)
> @@ -57,6 +57,7 @@
> CFG_BOOL("mute", 0, CFGF_NONE),
> CFG_BOOL("deaf", 0, CFGF_NONE),
> CFG_INT("host_dmax", 0, CFGF_NONE),
> + CFG_INT("host_tmax", 20, CFGF_NONE),
> CFG_INT("cleanup_threshold", 300, CFGF_NONE),
> CFG_BOOL("gexec", 0, CFGF_NONE),
> CFG_INT("send_metadata_interval", 0, CFGF_NONE),
>
>> I also added some explanations to the documentation, but am not sure
>> the explanation is really clear nor exact.
>
> it is correct, if a little strange, but will let any native speaker correct
> the grammar if needed.
>
> Committed revision 1376
>
> I also suspect that it will be probably better to also change the logic for
> gmond so that it will use the host_tmax value directly instead of a multiple
> of it with a hardcoded "4 attempts" to avoid confusion, and most likely also
> add some verification and documentation in the relationship that should be
> maintained between this value and the heartbeat, to avoid broken setups.
>
> Carlo
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
