>>> On 6/18/2008 at 4:10 PM, in message
<[EMAIL PROTECTED]>, Gilad Raphaelli
<[EMAIL PROTECTED]> wrote:

> 
> 
> 
> ----- Original Message ----
>> From: Brad Nicholes <[EMAIL PROTECTED]>
>> To: ganglia-developers@lists.sourceforge.net; Gilad Raphaelli 
> <[EMAIL PROTECTED]>
>> Sent: Thursday, June 19, 2008 12:20:48 AM
>> Subject: Re: [Ganglia-developers] Stacked Graphs
>> 
>> >>> On 6/17/2008 at 4:24 PM, in message
>> <[EMAIL PROTECTED]>, Gilad Raphaelli
>> wrote:
>> > I submitted the code for the stacked graphs item from the ganglia 3.1 
>> > wishlist in 
> http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=187 
>> > (in April).  It was reviewed by someone on #ganglia while ago but it never 
>> > made it into svn.  I assume it's a bit late for release with 3.1.0 - can I 
> get 
>> 
>> > in onto the list for review for 3.1.1?
>> > 
>> 
>> The format that the patch is in, prevents it from being easily applied to 
>> current source code.  Could you resubmit the patch against the latest code 
> in 
>> TRUNK in unified diff format so that the patch can be applied to the source 
> and 
>> tested?  Once that happens, then a backport proposal can be submitted for 
> the 
>> 3.1.x source code branch.  
>> 
>> Brad
> 
> svn diff against trunk now attached to the bug report.  Please let me know 
> if I screwed it up again.
> 

The patch looks good.  Now we just need somebody with a lot PHP web frontend 
experience than me to review the patch and determine if it should be committed 
to trunk.  Jesse, Bernard... I'll leave it up to you or anybody else with 
commit rights looking from some code to review. :)

Brad


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to