On Sun, Jul 06, 2008 at 07:57:39PM +0100, Stu Teasdale wrote:
> ... In the usual place: 
> http://www2.drogna.org/~stu/ganglia/ganglia3/sid/

where did you get that 1443 snapshot? that one was incorrectly built(*) and
is missing some patches from recent 3.1 snapshots which are relevant to
debian.

could you rebase your package to a more recent snapshot?, 1504 probably a
good choice :

  http://tapir.sajinet.com.pe/ganglia/ganglia-3.1.0.1504.tar.gz

> Still some minor issues to work through with unused linked shared 
> objects, but they're getting there :).

Something related and also of concern is that it seems our modules are built
bloated as you can see by comparing the default DSO built by configure/make
(in .libs) and the one built by hand :

$ make clean &>/dev/null
$ gcc -std=gnu99 -shared -lapr-1 -fpic -I/usr/include/apr-1 -I../../../include 
-I../../../lib -o modexample.so mod_example.c
$ make &>/dev/null
$ find . -name "*.so" -exec stat {} \;
  File: `./.libs/modexample.so'
  Size: 20878           Blocks: 48         IO Block: 4096   regular file
Device: 815h/2069d      Inode: 785069      Links: 1
Access: (0755/-rwxr-xr-x)  Uid: ( 1000/ carenas)   Gid: ( 1000/ carenas)
Access: 2008-07-06 23:19:03.000000000 -0700
Modify: 2008-07-06 23:19:03.000000000 -0700
Change: 2008-07-06 23:19:03.000000000 -0700
  File: `./modexample.so'
  Size: 12633           Blocks: 32         IO Block: 4096   regular file
Device: 815h/2069d      Inode: 3697174     Links: 1
Access: (0755/-rwxr-xr-x)  Uid: ( 1000/ carenas)   Gid: ( 1000/ carenas)
Access: 2008-07-06 23:18:15.000000000 -0700
Modify: 2008-07-06 23:18:15.000000000 -0700
Change: 2008-07-06 23:18:15.000000000 -0700

and neither of them is linked with libganglia, leaving debug_msg (and any
other function part of the "C" module interface that is being used,
undefined).

some comments/questions:

* we don't have srclib anymore :

cd srclib && /usr/bin/make distclean
/bin/sh: line 0: cd: srclib: No such file or directory
make: [clean] Error 1 (ignored)

* why are you linking explicitally gmetad to libganglia :

--- ganglia-3.1.0~r1443.orig/gmetad/Makefile.am
+++ ganglia-3.1.0~r1443/gmetad/Makefile.am
@@ -14,7 +14,7 @@
 gmetad_SOURCES =  gmetad.c cmdline.c cmdline.h gmetad.h data_thread.c \
    server.c process_xml.c rrd_helpers.c conf.c conf.h type_hash.c \
    xml_hash.c cleanup.c rrd_helpers.h
-gmetad_LDADD   = $(top_builddir)/lib/libganglia.la -lrrd -lm \
+gmetad_LDADD   = -L$(top_builddir)/lib/.libs -lganglia -lrrd -lm \
                  $(GLDADD)
 
 gmetad_LDFLAGS = $(GLDFLAGS)

* --enable-shared is the default, is that a protection against a change
of policy?

* what is --disable-rpath meant to do?

Carlo

(*) the nano version is incorrectly set to 999 generating an invalid soname
for libganglia as you can see by the following lintian warning :

W: libganglia1: package-name-doesnt-match-sonames libganglia-3.1.0.999-0

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to