>>> On 7/7/2008 at 10:41 AM, in message
<[EMAIL PROTECTED] 
, <[EMAIL PROTECTED]> wrote:

> 
> I notice that the ex_metric_info array is normally NULL terminated:
> 
> static Ganglia_25metric ex_metric_info[] =
> {
>     {0, NULL}
> };
> 
> 
> The function  ex_metric_init (apr_pool_t *p) populates a new array,
> metric_info, but doesn't add a NULL entry at the end.
> 
> If the memory area contains 0, then this is not a problem.  However, if
> the area after the end of the array doesn't contain 0 (either because it
> is uninitialised or because it has been allocated to something else)
> could this be a problem?
> 

Yes it is a problem.  I fixed this in mod_python but forgot about mod_multicpu 
and mod_status.  All of the other modules should be OK since they use static 
metric definitions.  I will get this fixed and proposed for backport to 3.1.

Brad


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to