On Tue, Nov 04, 2008 at 06:13:47PM -0700, Brad Nicholes wrote:
> Carlo,
> In the STATUS file you commented that the spoofing patch needs more work.
my comment was about the spoofing "feature" needing more work in 3.1 as you
pointed out below.
the patch just makes the problem bigger by adding several changes (more than
500 lines) on top of an implementation that has open regressions and that
will need to be cleaned up first IMHO.
> Can you explain what work needs to be done. Other than supporting the
> short commandline for spoofing a heartbeat, AFAICT everything is working
> as it should.
current 3.1, without the additional patch is missing the heartbeat spoofing
support as you pointed out, and is also exporting the spoofed data in the
XML which even if mostly harmless is a change of behaviour and should be
cleaned up as well (as it really adds no value and is inconsistent)
as for 3.1 with the patch added, there are the following problems :
* the added calls for toupper() in libgmond could result in undefined
behaviour in platforms where char is signed and toupper is implemented
using an array lookup (NetBSD, and probably HPUX and AIX)
* the proposed patch has some additional patches that will need to be
added on top of it (some of them already proposed and approved like
the modpython fixes, but some others still not even proposed)
> I have committed a spoofing example python module in trunk that spoofs
> cpu_util, boottime, heartbeat and osname for three imaginary machines.
> This spoof example module runs under both trunk and the patched 3.1.x.
Sadly I haven't been able to make it work, with `gmond -m` showing :
# gmond -m
(module python_module)
load_one One minute load average (module load_module)
...
and python modules in general not working anymore (linked against amd64's
python 2.5.2 in Linux)
the "C" interface seems to work fine at least in 3.1 (in trunk it messes
GMOND_STARTED as explained before)
> I have also created a patch for sending a heartbeat through the shortened
> commandline which has been proposed as a follow-on backport.
saw that, not sure about the needed dependency in the modular spoofing
support as IMHO a change to gmetric should be independent of that.
> If there is nothing else missing, can we get this one backported?
with the availability of a proposed backport patch that fixes the conflicts
and an example python spoofing module it should be easier to do so but as I
pointed before not yet sure enough to stamp a vote on it, but I agree we
should get this patch/feature released with the next release.
Carlo
PS. can the full list of patches needed from backport be added to the list, I
suspect r1615 is missing as that should be required for r1622 which I added
and is included in your consolidated patch
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
