Recently I started testing the svn version of the web scripts and found
a few bugs.  I tried committing the patches myself using my sourceforge
account (smithj4), since I am listed as a developer for the project, but
I got an error:

svn: Commit failed (details follow):
svn: MKACTIVITY of '/svnroot/ganglia/!
svn/act/14edbee0-72dd-4717-9799-58221d816726': 403 Forbidden
(https://ganglia.svn.sourceforge.net)


Anyway, the patch I was trying to commit is attached below, and here is
the log message I was going to use:

Fixed graph zooming and make sure the default summary graph size
overrides the size selected for the cluster graphs.

Thanks,
~Jason


-- 
/------------------------------------------------------------------\
|  Jason A. Smith                          Email:  smit...@bnl.gov |
|  Atlas Computing Facility, Bldg. 510M    Phone: +1-631-344-4226  |
|  Brookhaven National Lab, P.O. Box 5000  Fax:   +1-631-344-7616  |
|  Upton, NY 11973-5000,  U.S.A.                                   |
\------------------------------------------------------------------/

Index: monitor-core/web/templates/default/host_view.tpl
===================================================================
--- monitor-core/web/templates/default/host_view.tpl	(revision 1939)
+++ monitor-core/web/templates/default/host_view.tpl	(working copy)
@@ -60,25 +60,25 @@
 </TD>
 
 <TD ALIGN="CENTER" VALIGN="TOP" WIDTH="395">
-<A HREF="./graph.php?g=load_report&amp;z=large&amp;c={cluster_url}&amp;{graphargs}">
+<A HREF="./graph.php?{graphargs}&amp;g=load_report&amp;z=large&amp;c={cluster_url}">
 <IMG BORDER=0 ALT="{cluster_url} LOAD"
-   SRC="./graph.php?g=load_report&amp;z=medium&amp;c={cluster_url}&amp;{graphargs}">
+   SRC="./graph.php?{graphargs}&amp;g=load_report&amp;z=medium&amp;c={cluster_url}">
 </A>
-<A HREF="./graph.php?g=mem_report&amp;z=large&amp;c={cluster_url}&amp;{graphargs}">
+<A HREF="./graph.php?{graphargs}&amp;g=mem_report&amp;z=large&amp;c={cluster_url}">
 <IMG BORDER=0 ALT="{cluster_url} MEM"
-   SRC="./graph.php?g=mem_report&amp;z=medium&amp;c={cluster_url}&amp;{graphargs}">
+   SRC="./graph.php?{graphargs}&amp;g=mem_report&amp;z=medium&amp;c={cluster_url}">
 </A>
-<A HREF="./graph.php?g=cpu_report&amp;z=large&amp;c={cluster_url}&amp;{graphargs}">
+<A HREF="./graph.php?{graphargs}&amp;g=cpu_report&amp;z=large&amp;c={cluster_url}">
 <IMG BORDER=0 ALT="{cluster_url} CPU"
-   SRC="./graph.php?g=cpu_report&amp;z=medium&amp;c={cluster_url}&amp;{graphargs}">
+   SRC="./graph.php?{graphargs}&amp;g=cpu_report&amp;z=medium&amp;c={cluster_url}">
 </A>
-<A HREF="./graph.php?g=network_report&amp;z=large&amp;c={cluster_url}&amp;{graphargs}">
+<A HREF="./graph.php?{graphargs}&amp;g=network_report&amp;z=large&amp;c={cluster_url}">
 <IMG BORDER=0 ALT="{cluster_url} NETWORK"
-   SRC="./graph.php?g=network_report&amp;z=medium&amp;c={cluster_url}&amp;{graphargs}">
+   SRC="./graph.php?{graphargs}&amp;g=network_report&amp;z=medium&amp;c={cluster_url}">
 </A>
-<A HREF="./graph.php?g=packet_report&amp;z=large&amp;c={cluster_url}&amp;{graphargs}">
+<A HREF="./graph.php?{graphargs}&amp;g=packet_report&amp;z=large&amp;c={cluster_url}">
 <IMG BORDER=0 ALT="{cluster_url} PACKETS"
-   SRC="./graph.php?g=packet_report&amp;z=medium&amp;c={cluster_url}&amp;{graphargs}">
+   SRC="./graph.php?{graphargs}&amp;g=packet_report&amp;z=medium&amp;c={cluster_url}">
 </A>
 
 </TD>
Index: monitor-core/web/templates/default/cluster_view.tpl
===================================================================
--- monitor-core/web/templates/default/cluster_view.tpl	(revision 1939)
+++ monitor-core/web/templates/default/cluster_view.tpl	(working copy)
@@ -21,25 +21,25 @@
 </TD>
 
 <TD ROWSPAN=2 ALIGN="CENTER" VALIGN=top>
-<A HREF="./graph.php?g=load_report&amp;z=large&amp;{graph_args}">
+<A HREF="./graph.php?{graph_args}&amp;g=load_report&amp;z=large">
 <IMG BORDER=0 ALT="{cluster} LOAD"
-   SRC="./graph.php?g=load_report&amp;z=medium&amp;{graph_args}">
+   SRC="./graph.php?{graph_args}&amp;g=load_report&amp;z=medium">
 </A>
-<A HREF="./graph.php?g=mem_report&amp;z=large&amp;{graph_args}">
+<A HREF="./graph.php?{graph_args}&amp;g=mem_report&amp;z=large">
 <IMG BORDER=0 ALT="{cluster} MEM"
-   SRC="./graph.php?g=mem_report&amp;z=medium&amp;{graph_args}">
+   SRC="./graph.php?{graph_args}&amp;g=mem_report&amp;z=medium">
 </A>
-<A HREF="./graph.php?g=cpu_report&amp;z=large&amp;{graph_args}">
+<A HREF="./graph.php?{graph_args}&amp;g=cpu_report&amp;z=large">
 <IMG BORDER=0 ALT="{cluster} CPU"
-   SRC="./graph.php?g=cpu_report&amp;z=medium&amp;{graph_args}">
+   SRC="./graph.php?{graph_args}&amp;g=cpu_report&amp;z=medium">
 </A>
-<A HREF="./graph.php?g=network_report&amp;z=large&amp;{graph_args}">
+<A HREF="./graph.php?{graph_args}&amp;g=network_report&amp;z=large">
 <IMG BORDER=0 ALT="{cluster} NETWORK"
-    SRC="./graph.php?g=network_report&amp;z=medium&amp;{graph_args}">
+    SRC="./graph.php?{graph_args}&amp;g=network_report&amp;z=medium">
 </A>
 <!-- START BLOCK : optional_graphs -->
-<A HREF="./graph.php?g={name}_report&amp;z=large&amp;{graph_args}">
-<IMG BORDER=0 ALT="{cluster} {name}" SRC="./graph.php?g={name}_report&amp;z=medium&amp;{graph_args}">
+<A HREF="./graph.php?{graph_args}&amp;g={name}_report&amp;z=large">
+<IMG BORDER=0 ALT="{cluster} {name}" SRC="./graph.php?{graph_args}&amp;g={name}_report&amp;z=medium">
 </A>
 <!-- END BLOCK : optional_graphs -->
 </TD>

Attachment: smime.p7s
Description: S/MIME cryptographic signature

------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to