1)  I've made a few small changes to the ganglia.spc.in file (r2087
and r2088) to use the %{version} tag instead of @VERSION@ in a few
places.  This is considered to be 'correct' according to RPM package
building, and allows for easier upgrades if a user need to take the
.spec file and update it themselves.  The initial './bootstrap' will
still have to be run, since @VERSION@ does need to be expanded at
least once to define an RPM macro, and set a few items in the
comments.

2) The 'Release' macro is not properly set in the specfile.  This is
because it is defined by the @REL@ autoconf variable, which is
hard-coded to "1" in configure.in.  I propose that we change this.
The simplest thing would be to remove @REL@ from ganglia.spec.in, and
update the "Release" macro manually.  The other option is to remember
to update REL in configure.in each time a change is made to the
ganglia.spec.in file.

3) There are several sub-packages created by the specfile:
  libganglia-3_1_0
  ganglia-python
  ganglia-web (noarch)
  ganglia-devel
  ganglia-gmond
  ganglia-gmetad

The ganglia-devel package includes a /usr/lib/libganglia.so *symlink*
that points to the actual .so included in the libganglia package.  I
think that this symlink should be in the libganglia package.  Is there
a particular reason it is in ganglia-devel instead?

-- 
Jesse Becker

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to