Great thanks. On Wed, 7 Mar 2012, Daniel Pocock wrote:
> > > I didn't get any comment on this, so I've promoted lib/file.h to > include/gm_file.h for use by module developers > > As part of the change, > > - I didn't want to expose SYNAPSE_FAILURE, so slurpfile() now returns > SLURP_FAILURE on error > > - I noticed that there are different definitions of skip_whitespace(), > so I renamed one of them, given that C doesn't support overloading > > Binary compatibility should not be affected so it should be safe for > this change to go out in the next 3.3.X series release > > > On 08/02/12 15:50, Daniel Pocock wrote: >> >> >> In repackaging mod_multicpu as part of ganglia-modules-linux, I've >> noticed that it uses two non-public API functions and one #define: >> >> >> char *skip_whitespace (const char *p); >> char *skip_token (const char *p); >> >> #define SYNAPSE_FAILURE -1 >> >> Co-incidentally, the IO module uses these too >> >> Should these go in the public API of Ganglia, in other words, in the >> include files that are deployed to /usr/include? Is there a compelling >> reason not to do that? I'm guessing they were just overlooked when the >> module architecture was introduced and they could be migrated to the >> public API in the next minor release (e.g. 3.3.1) >> >> As a workaround, to enable packaging of ganglia-modules-linux, I've just >> copied those items into a header file in the module project: >> >> https://sourceforge.net/p/gmod-linux/code/ci/f6af30aa37cc870d3169276d9f6743771baf1b90/tree/include/ganglia_mod_workaround.h >> >> >> >> ------------------------------------------------------------------------------ >> Keep Your Developer Skills Current with LearnDevNow! >> The most comprehensive online learning library for Microsoft developers >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> Metro Style Apps, more. Free future releases when you subscribe now! >> http://p.sf.net/sfu/learndevnow-d2d >> _______________________________________________ >> Ganglia-developers mailing list >> Ganglia-developers@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/ganglia-developers > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > Ganglia-developers mailing list > Ganglia-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ganglia-developers > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
