On 03/20/2012 06:19 PM, Daniel Pocock wrote: > b) should Michael (or anyone else) need to modify Makefile.am from a > tarball? If there are regular changes to Makefile.am after releases are > made, shouldn't we find a way to incorporate such changes into trunk, or > provide more variables for people to set things at build time?
Let me explain my "motivation" to make changes to Makefile.am: I am maintaining for AIX and Linux on Power a couple of additional gmond DSO modules written in C. As those are probably only useful for people running AIX (or Linux on Power) I don't see a generic way to incorporate such changes into trunk. In order to compile and package the gmond module I intentionally keep the release tar.gz unchanged, i.e., any module is represented by a large source code patch against the respective release tar.gz. This is also the "RPM-way" of doing things (i.e., keep the vanilla source unchanged and anything else should be provided as a source code patch). So the patch for example for a metric called "mod_netif" adds or changes the following files/directories: ./gmond/modules/conf.d/netif.conf ./gmond/modules/netif/mod_netif-linux.c ./gmond/modules/netif/Makefile.am ./gmond/modules/Makefile.am ./gmond/Makefile.am ./configure.in Now one needs to run "autoreconf -fi" to incorporate the applied patches and that the respective "Makefile.in" files are generated from the patched "Makefile.am" files. I also keep separate SPEC files for all modules and have thus a clean separation of the original Ganglia release tar.gz files and my modules. In addition I can change the RPM "release" number independently of the core ganglia RPM release number which provides further flexibility. Regards, Michael ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
