Hi J.T.:

Any chance you can come up with a patch?

Thanks,

Bernard

On Sat, Feb 15, 2014 at 7:37 AM, J.T. Conklin <j...@acorntoolworks.com> wrote:
> j...@acorntoolworks.com (J.T. Conklin) writes:
>> I'm having a few problems with a new web interface deployment that I
>> haven't been able to debug.  When the home page refreshes, or one of
>> the buttons at the top of the page are selected, the generated URL
>> opens an empty page.
>>
>> For example, after a refresh I get:
>>
>>     
>> http://ganglia.example.com/ganglia-2/?r=hour&cs=&ce=&m=load_one&s=by+name&c=&tab=m&vn=&hide-hf=false
>>
>> I've found when I manually remove the "&hide-hf=false" from the URL,
>> the page renders, but I have not yet been able to determine where this
>> is generated, or why the page doesn't render when it's present.
>
> I've since tracked this down to:
>
>     if (isset($_GET["hide-hf"]) && filter_input(INPUT_GET, "hide-hf", 
> FILTER_VALIDATE_BOOLEAN, array("flags" => FILTER_NULL_ON_FAILURE))) {
>       $data->assign("hide_header", true);
>     }
>
> in header.php and footer.php, and the fact that PHP on Centos 5.5 is
> 5.1.6, thus predates filter_input(). I commented these two lines out,
> and now the web UI works as expected.
>
> Since these are the only two places where filter_input() are used,
> thus the only thing requiring PHP 5.2+, it may be worth using back-
> wards compatible code to fetch the hide-hf param.  The other params
> are not validated, and I can't see what makes hide-hf more important.
>
>     --jtc
>
> --
> J.T. Conklin
>
> ------------------------------------------------------------------------------
> Android apps run on BlackBerry 10
> Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
> Now with support for Jelly Bean, Bluetooth, Mapview and more.
> Get your Android app in front of a whole new audience.  Start now.
> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
> _______________________________________________
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to