------- Comment #9 from rep dot nop at aon dot at 2005-10-16 16:19 ------- (In reply to comment #8) > (In reply to comment #7) > > Was the non-standard behaviour in 3.4 a bug or a feature? In any case, > > isn't it > > reasonable to mention the -combine option in the error message? > > The behavior in 3.4 was a feature, IIRC not well documented one. > > > Something like: > > > > fatal ("cannot specify -o with -c or -S with multiple files. Try -combine"); > > Well what happens when you do: > > gcc -combine t.cc t.c -c -o t.o > We need an error but what should it be. I think leaving out the -combine will > not confuse > people as they should be reading the documention anyways.
Yes, they should, still i'd prefer that a hint to -combine is emitted (see attached fix22544.diff2.txt) Also your patch had odd whitespace. > > > I don't have the gcc code, but you check for have_c && have_o, but can > > have_o > > ever be true for -S? > > have_c is set for both -S and -c. > -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22544